Skip to content

LG-10759 Fix State Address Validation #9134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svalexander merged 14 commits into from
Sep 11, 2023
Merged

LG-10759 Fix State Address Validation #9134

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2756fec
add address and city to validation and update spec
svalexander Sep 1, 2023
fd41f6f
changelog: Bug Fixes, State id form, fix validation for address line …
svalexander Sep 1, 2023
8fdce78
check dav for addres1 and city validation
svalexander Sep 5, 2023
f916cff
lint fix
svalexander Sep 5, 2023
1b8f8c0
disable lint message
svalexander Sep 5, 2023
7106d41
update spec
svalexander Sep 7, 2023
eb283df
Merge branch 'main' into shannon/lg-10759-fix-address-form-validation
svalexander Sep 7, 2023
66d5c5a
update specs with capture_secondary_id_enabled
svalexander Sep 7, 2023
54c683b
initialize capture_secondary_id_enabled and lint fixes
svalexander Sep 8, 2023
f650213
lint fix for state id step
svalexander Sep 8, 2023
0cfe415
lint fix in_person_helper
svalexander Sep 8, 2023
4c41ba0
remove dav from in person helper and spec
svalexander Sep 8, 2023
392a606
remove dav from step helper and ssn spec
svalexander Sep 11, 2023
08bb6e8
update state id step spec and lint
svalexander Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/validators/idv/form_state_id_validator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ module FormStateIdValidator
:dob,
:state_id_jurisdiction,
:state_id_number,
:identity_doc_address1,
:identity_doc_city,
presence: true

validates_with UspsInPersonProofing::TransliterableValidator,
Expand Down
3 changes: 3 additions & 0 deletions spec/forms/idv/state_id_form_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
dob: valid_dob,
identity_doc_address1: Faker::Address.street_address,
identity_doc_address2: Faker::Address.secondary_address,
identity_doc_city: Faker::Address.city,
identity_doc_zipcode: Faker::Address.zip_code,
identity_doc_address_state: Faker::Address.state_abbr,
same_address_as_id: 'true',
Expand All @@ -36,6 +37,7 @@
dob: too_young_dob,
identity_doc_address1: Faker::Address.street_address,
identity_doc_address2: Faker::Address.secondary_address,
identity_doc_city: Faker::Address.city,
identity_doc_zipcode: Faker::Address.zip_code,
identity_doc_address_state: Faker::Address.state_abbr,
same_address_as_id: 'true',
Expand All @@ -51,6 +53,7 @@
dob: valid_dob,
identity_doc_address1: Faker::Address.street_address,
identity_doc_address2: Faker::Address.secondary_address,
identity_doc_city: Faker::Address.city,
identity_doc_zipcode: Faker::Address.zip_code,
identity_doc_address_state: Faker::Address.state_abbr,
same_address_as_id: 'true',
Expand Down