LG-10447 - remove no longer used Acuant SDK 11.8.0 files#9130
Merged
Conversation
mitchellhenke
approved these changes
Aug 31, 2023
aduth
approved these changes
Sep 1, 2023
dawei-nava
approved these changes
Sep 1, 2023
charleyf
approved these changes
Sep 1, 2023
Contributor
charleyf
left a comment
charleyf
left a comment
There was a problem hiding this comment.
I checked:
- 11.8.0 is the oldest version of Acuant.
- Adding a new dir
public/acuant/12.0.1causes the test to fail.
Note/Nit:
- Removing all but one acuant version caused three tests to fail.
- This makes it seem like the test you modified only needs to check that we have "no more than three" and doesn't need to worry about the lower bound.
- I'm not worried about this, either way the tests are telling us that something's wrong.
changelog: Internal, Document Authentication, Remove unused Acuant SDK 11.8.0
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
amirbey
force-pushed
the
amirbey/LG-10447-remove-stale-acuant-sdk-versions
branch
from
3ddd87f to
bbc3257
Compare
amirbey
deleted the
amirbey/LG-10447-remove-stale-acuant-sdk-versions
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10447
🛠 Summary of changes
Remove no longer used Acuant SDK 11.8.0 files
📜 Testing Plan
Provide a checklist of steps to confirm the changes.