Update identity verification report to work for older logs (LG-10875)#9128
Merged
zachmargolis merged 2 commits intomainfrom Sep 1, 2023
Merged
Conversation
changelog: Internal, Reporting, Update identity verification report query
mitchellhenke
approved these changes
Aug 31, 2023
soniaconnolly
approved these changes
Aug 31, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM.
Re: naming it legacy_deactivation_reason, there are some remaining deactivation_reasons that aren't legacy (password reset, verification canceled) but I'm not sure they would come up in this context.
Contributor
Author
What about renaming to Update: went for it in 3e338e2 |
zachmargolis
deleted the
margolis-update-identity-verification-report-legacy
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Idv: Final Resolutionevents from a year ago will not have the same properties are current ones, they'll havedeactivation_reasonSolution:
Add
coalesce()to default these values to false and check that there isn't the olderdeactivation_reasonproperty