Skip to content

LG-8289 OTP clarity #9122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amirbey merged 4 commits into from
Aug 31, 2023
Merged

LG-8289 OTP clarity #9122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b7dac9
add a pause before and after voice otp characters
amirbey Aug 29, 2023
b95db4d
add the pause after the last otp character
amirbey Aug 30, 2023
fd72894
happy linting
amirbey Aug 30, 2023
3ca2499
refactor
amirbey Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/telephony/otp_sender.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def log_response(response, context:)
def otp_transformed_for_channel
return otp if channel != :voice

otp.chars.join(" <break time='#{Telephony.config.voice_pause_time}' /> ")
[*otp.chars, ''].join(" <break time='#{Telephony.config.voice_pause_time}' /> ")
end

def wrap_in_ssml_if_needed(message)
Expand Down
10 changes: 5 additions & 5 deletions spec/lib/telephony/otp_sender_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@
<prosody rate='slow'>
Hello! Your 6-digit #{APP_NAME} one-time code is,
1 <break time='0.5s' /> 2 <break time='0.5s' /> 3 <break time='0.5s' />
4 <break time='0.5s' /> 5 <break time='0.5s' /> 6.
4 <break time='0.5s' /> 5 <break time='0.5s' /> 6 <break time='0.5s' /> .
XML

adapter = instance_double(Telephony::Pinpoint::VoiceSender)
Expand All @@ -191,7 +191,7 @@
<prosody rate='slow'>
Hello! Your 6-digit #{APP_NAME} one-time code is,
1 <break time='0.5s' /> 2 <break time='0.5s' /> 3 <break time='0.5s' />
4 <break time='0.5s' /> 5 <break time='0.5s' /> 6.
4 <break time='0.5s' /> 5 <break time='0.5s' /> 6 <break time='0.5s' /> .
XML

adapter = instance_double(Telephony::Pinpoint::VoiceSender)
Expand All @@ -215,7 +215,7 @@
<prosody rate='slow'>
Hello! Your 6-character #{APP_NAME} one-time code is,
1 <break time='0.5s' /> 2 <break time='0.5s' /> 3 <break time='0.5s' />
4 <break time='0.5s' /> 5 <break time='0.5s' /> 6.
4 <break time='0.5s' /> 5 <break time='0.5s' /> 6 <break time='0.5s' /> .
XML

adapter = instance_double(Telephony::Pinpoint::VoiceSender)
Expand Down Expand Up @@ -272,7 +272,7 @@
expect(otp_transformed_for_channel).
to eq(
"1 <break time='0.5s' /> 2 <break time='0.5s' /> 3 <break time='0.5s' /> 4 "\
"<break time='0.5s' /> 5 <break time='0.5s' /> 6",
"<break time='0.5s' /> 5 <break time='0.5s' /> 6 <break time='0.5s' /> ",
)
end
end
Expand All @@ -284,7 +284,7 @@
expect(otp_transformed_for_channel).
to eq(
"A <break time='0.5s' /> B <break time='0.5s' /> C <break time='0.5s' /> 1 "\
"<break time='0.5s' /> 2 <break time='0.5s' /> 3",
"<break time='0.5s' /> 2 <break time='0.5s' /> 3 <break time='0.5s' /> ",
)
end
end
Expand Down