Merged
Conversation
…update sms text with contact number
svalexander
requested review from
a team,
allis-green and
sheldon-b
and removed request for
a team
svalexander
changed the title
svalexander
commented
Aug 31, 2023
| passed_enrollment.update!(proofed_at: Time.zone.now) | ||
| proofed_date = Time.zone.now.strftime('%m/%d/%Y') | ||
| phone_number = passed_enrollment.notification_phone_configuration.formatted_phone | ||
| country_code = '(844) 555-5555' |
Contributor
Author
There was a problem hiding this comment.
change to contact_number
Contributor
|
I would consider adding a test just to check that IdentityConfig.store.idv_contact_phone_number is present/exists. Everything else looks good other than the one change you added. Reach out slack when it is updated and I will hit approve. |
gina-yamada
reviewed
Sep 1, 2023
config/locales/telephony/en.yml
Outdated
| confirmation_ipp_enrollment_result: | ||
| sms: |- | ||
| %{app_name}: You attempted to verify your identity at a Post Office on %{proof_date}. Check your email for your result. | ||
| %{app_name}: You visited the Post Office on %{proof_date}. Check your email for your result. Not you? Report this right away: %{contact_number} |
Contributor
There was a problem hiding this comment.
Update message does not contain YOUR.
doc reads: Check email for your result.
you have: Check your email for your result.
gina-yamada
suggested changes
Sep 1, 2023
svalexander
changed the title
gina-yamada
approved these changes
Sep 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10614
🛠 Summary of changes
Change sms message to match new copy that includes contact number.
Note for designer reviewing: There are no screenshots available, in lieu of those the string files can be used to confirm the text is correct.
📜 Testing Plan
To be tested after merging into dev.
https://idp.dev.identitysandbox.gov/