Skip to content

LG-10691: ensure user is authenticated in phone controller before accessing session #9082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amirbey merged 5 commits into from
Aug 25, 2023
Merged

LG-10691: ensure user is authenticated in phone controller before accessing session #9082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84b694d
fix ordering of confirm_two_factor_authenticated filter in phone cont…
amirbey Aug 24, 2023
859a292
test hybrid doc user via sendlink on desktop to access phone step
amirbey Aug 24, 2023
7b09c08
verify user is logged out
amirbey Aug 24, 2023
8a29667
Regression spec - jump to Phone step to confirm it doesn't cause errors
soniaconnolly Aug 24, 2023
8fcbcff
remove test not needed
amirbey Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/controllers/concerns/idv/phone_otp_rate_limitable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ module PhoneOtpRateLimitable
extend ActiveSupport::Concern

included do
before_action :confirm_two_factor_authenticated
before_action :handle_locked_out_user
end

Expand Down
1 change: 0 additions & 1 deletion app/controllers/concerns/idv/phone_otp_sendable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ module PhoneOtpSendable
extend ActiveSupport::Concern

included do
before_action :confirm_two_factor_authenticated
before_action :handle_locked_out_user
end

Expand Down
2 changes: 1 addition & 1 deletion app/controllers/idv/otp_verification_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class OtpVerificationController < ApplicationController
include StepIndicatorConcern
include PhoneOtpRateLimitable

# confirm_two_factor_authenticated before action is in PhoneOtpRateLimitable
before_action :confirm_two_factor_authenticated
before_action :confirm_step_needed
before_action :confirm_otp_sent
before_action :set_code
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/idv/resend_otp_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class ResendOtpController < ApplicationController
include PhoneOtpRateLimitable
include PhoneOtpSendable

# confirm_two_factor_authenticated before action is in PhoneOtpRateLimitable
before_action :confirm_two_factor_authenticated
before_action :confirm_user_phone_confirmation_needed
before_action :confirm_user_phone_confirmation_session_started

Expand Down
5 changes: 5 additions & 0 deletions spec/features/idv/hybrid_mobile/hybrid_mobile_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@
expect(page).to have_current_path(root_url)
visit idv_hybrid_mobile_document_capture_url

# Confirm that jumping to Phone page does not cause errors
visit idv_phone_url
expect(page).to have_current_path(root_url)
visit idv_hybrid_mobile_document_capture_url

# Confirm that jumping to Welcome page does not cause errors
# This was added for the GettingStarted A/B Test
visit idv_welcome_url
Expand Down