Skip to content

Update email deliveries script to include email action#9070

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/add-email-action-to-on-call-email-helper
Aug 23, 2023
Merged

Update email deliveries script to include email action#9070
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/add-email-action-to-on-call-email-helper

Conversation

@mitchellhenke
Copy link
Contributor

🛠 Summary of changes

Follow-up to #8691 to include the type of email in the result. Example output:

+--------------------------------------+-------------------------+--------------------------------------------------------------+-----------------------------+----------------+
| user_id                              | timestamp               | message_id                                                   | email_action                | events         |
+--------------------------------------+-------------------------+--------------------------------------------------------------+-----------------------------+----------------+
| aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa | 2023-08-23 12:00:00.000 | 0000000000000000-00000000-0000-0000-0000-000000000000-000000 | account_reset_granted       | Send, Delivery |
+--------------------------------------+-------------------------+--------------------------------------------------------------+-----------------------------+----------------+

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You'll need to update spec/bin/oncall/email-deliveries_spec.rb too

changelog: Internal, Scripts, Update email deliveries script to include email action
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/add-email-action-to-on-call-email-helper branch from 10b676f to 64bba6c Compare August 23, 2023 16:44
@mitchellhenke mitchellhenke merged commit 0879eee into main Aug 23, 2023
@mitchellhenke mitchellhenke deleted the mitchellhenke/add-email-action-to-on-call-email-helper branch August 23, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants