LG-10658: Add analytics_id to logged Verify Info proofing result#9064
Merged
LG-10658: Add analytics_id to logged Verify Info proofing result#9064
Conversation
changelog: Internal, In-Person Proofing, Differentiate between remote and in-person flow Instant Verify / AAMVA proofing results in analytics
soniaconnolly
approved these changes
Aug 23, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. Ran through the remote flow past VerifyInfo and the log event looks as described.
| end | ||
|
|
||
| analytics.idv_doc_auth_verify_proofing_results(**form_response.to_h) | ||
| analytics.idv_doc_auth_verify_proofing_results(**analytics_arguments, **form_response.to_h) |
Contributor
There was a problem hiding this comment.
That's a good idea, to merge in analytics_arguments from the calling controller! I added the ab_test_analytics_buckets here, so that can be taken out in this PR.
…ley/lg-10658-add-analytics-id-to-verify-result
NavaTim
deleted the
tbradley/lg-10658-add-analytics-id-to-verify-result
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
🛠 Summary of changes
Differentiate between remote and in-person proofing results for LN InstantVerify and AAMVA in analytics.
Note: The approach used here adds a few additional fields to the analytics event beyond what is strictly required.
Tagging @18F/identity-ada in case the additional fields should be excluded.
Additional fields:
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
name=IdV: doc auth verify proofing resultsproperties.event_properties.analytics_id=In Person Proofingname=IdV: doc auth verify proofing resultsproperties.event_properties.analytics_id=Doc Auth