Inform user that a service provider request is requiring re-authentication if they are logged out due to it (LG-10661)#9053
Merged
mitchellhenke merged 5 commits intomainfrom Aug 23, 2023
Conversation
3cb53a7 to
eee0665
Compare
…ation if they are logged out due to it changelog: User-Facing Improvements, Sign-In, Inform user that a service provider request is requiring re-authentication if they are logged out due to it
eee0665 to
57316b7
Compare
spec/controllers/concerns/forced_reauthentication_concern_spec.rb
Outdated
Show resolved
Hide resolved
aduth
reviewed
Aug 22, 2023
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
zachmargolis
approved these changes
Aug 22, 2023
aduth
approved these changes
Aug 22, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10661
🛠 Summary of changes
Currently, if you are fully authenticated and initiate an authorization request with a service provider that requests forced re-authentication (via login=prompt in OIDC or ForceAuhthn in SAML), the session is terminated without any notification. We are working on other changes to improve this experience, but this is a shorter-term change to try to communicate this behavior better to the end user. The message should not be displayed if the session is not terminated.
Awaiting translations at the moment.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After: