Skip to content

LG-10576 delete threatmetrix session id from flow session #9049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soniaconnolly merged 2 commits into from
Aug 23, 2023
Merged

LG-10576 delete threatmetrix session id from flow session #9049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10cd739
Delete flow_session[:threatmetrix_session_id]
soniaconnolly Aug 21, 2023
58389b3
Test threatmetrix_session_id with :show, not :upddate
soniaconnolly Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/controllers/concerns/idv/verify_info_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ def shared_update
should_proof_state_id: should_use_aamva?(pii),
trace_id: amzn_trace_id,
user_id: current_user.id,
threatmetrix_session_id:
idv_session.threatmetrix_session_id || flow_session[:threatmetrix_session_id],
threatmetrix_session_id: idv_session.threatmetrix_session_id,
request_ip: request.remote_ip,
double_address_verification: capture_secondary_id_enabled,
)
Expand Down
8 changes: 2 additions & 6 deletions app/services/idv/steps/threat_metrix_step_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,8 @@ def threatmetrix_view_variables
end

def generate_threatmetrix_session_id
if !updating_ssn?
idv_session.threatmetrix_session_id = SecureRandom.uuid
# for 50/50 state, to be removed in next deploy
flow_session[:threatmetrix_session_id] = idv_session.threatmetrix_session_id
end
idv_session.threatmetrix_session_id || flow_session[:threatmetrix_session_id]
idv_session.threatmetrix_session_id = SecureRandom.uuid if !updating_ssn?
idv_session.threatmetrix_session_id
end

# @return [Array<String>]
Expand Down
16 changes: 1 addition & 15 deletions spec/controllers/idv/in_person/ssn_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,8 @@
)
end

it 'adds a session id to flow session' do
get :show
expect(flow_session[:threatmetrix_session_id]).to_not eq(nil)
end

it 'adds a threatmetrix session id to idv_session' do
get :show
expect(subject.idv_session.threatmetrix_session_id).to_not eq(nil)
expect { get :show }.to change { subject.idv_session.threatmetrix_session_id }.from(nil)
end

context 'with an ssn in session' do
Expand Down Expand Up @@ -179,14 +173,6 @@
end

it 'does not change threatmetrix_session_id when updating ssn' do
flow_session[:pii_from_user][:ssn] = ssn
put :update, params: params
session_id = flow_session[:threatmetrix_session_id]
subject.threatmetrix_view_variables
expect(flow_session[:threatmetrix_session_id]).to eq(session_id)
end

it 'does not change idv_session threatmetrix_session_id when updating ssn' do
flow_session[:pii_from_user][:ssn] = ssn
put :update, params: params
session_id = subject.idv_session.threatmetrix_session_id
Expand Down
26 changes: 5 additions & 21 deletions spec/controllers/idv/ssn_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@
)
end

it 'adds a threatmetrix session id to idv_session' do
expect { get :show }.to change { subject.idv_session.threatmetrix_session_id }.from(nil)
end

context 'with an ssn in session' do
let(:referer) { idv_document_capture_url }
before do
Expand Down Expand Up @@ -216,27 +220,7 @@
end
end

it 'adds a threatmetrix session id to flow session' do
put :update, params: params
subject.threatmetrix_view_variables
expect(flow_session[:threatmetrix_session_id]).to_not eq(nil)
end

it 'does not change flow_session threatmetrix_session_id when updating ssn' do
flow_session['pii_from_doc'][:ssn] = ssn
put :update, params: params
session_id = flow_session[:threatmetrix_session_id]
subject.threatmetrix_view_variables
expect(flow_session[:threatmetrix_session_id]).to eq(session_id)
end

it 'adds a threatmetrix session id to idv_session' do
put :update, params: params
subject.threatmetrix_view_variables
expect(subject.idv_session.threatmetrix_session_id).to_not eq(nil)
end

it 'does not change idv_session threatmetrix_session_id when updating ssn' do
it 'does not change threatmetrix_session_id when updating ssn' do
flow_session['pii_from_doc'][:ssn] = ssn
put :update, params: params
session_id = subject.idv_session.threatmetrix_session_id
Expand Down