Send in-person proofing notification SMS in user's selected email language#9045
Merged
tomas-nava merged 4 commits intomainfrom Aug 22, 2023
Merged
Conversation
changelog: User-Facing Improvements, In-person Proofing, Send sms notification in selected email language
tomas-nava
requested review from
a team and
racingspider
and removed request for
a team and
JackRyan1989
gina-yamada
approved these changes
Aug 21, 2023
| proof_date: proof_date, | ||
| ) | ||
| with_user_locale(enrollment.user) do | ||
| proof_date = enrollment.proofed_at ? I18n.l(enrollment.proofed_at, format: :sms_date) : 'NA' |
Contributor
There was a problem hiding this comment.
does NA need to be translated? or is it identical in all our locals?
Contributor
There was a problem hiding this comment.
If proof_date is nullable, I feel like it would probably be easier to have two versions of the string (one with it, one without it) than to try to match translating the NA in context like that
Contributor
Author
There was a problem hiding this comment.
thank you, I'm following up on this with the team. I don't think it is nullable, and if it is, we should just send a message without the date, not with "NA" inserted in the date's place.
added 2 commits
August 22, 2023 07:54
…otification-in-chosen-language
zachmargolis
approved these changes
Aug 22, 2023
tomas-nava
deleted the
tomas/send-proofing-notification-in-chosen-language
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Related to LG-10124 and LG-10126
🛠 Summary of changes
Send in-person proofing notification SMS in user's selected email language.
Note: sending SMS proofing notifications is not in production yet.
📜 Testing Plan
Once this PR is merged and in dev