Conversation
bacd42b to
c41e9ac
Compare
config/locales/tooltips/en.yml
Outdated
There was a problem hiding this comment.
Should authentication application be authenticator app to match the main text on the screen?
There was a problem hiding this comment.
Will ask what copy thinks!
c41e9ac to
4605b7c
Compare
|
I believe I have amended the wording to |
|
I also changed the heading from |
|
Looks good, although I just noticed something else. Is it OK for us to name Google Authenticator and Authy? Will that make it look like we endorse those products? |
|
We would have to ask about that as well, I'm not sure. I suppose it depends on if providing examples can be construed as an endorsement. I guess I wouldn't be too surprised if there were a rule against it... |
|
I wonder if rather than having the tooltip icon sort of squeezed in between sentences if we could just make |
|
I personally don't like it there, but we don't have a consistent look for these (some places use the ? some use links). If we want to just start removing these bubbles and using links I am down. |
|
hey gang! i recently stumbled across this issue and i'd love to put a little polish on the design of this tooltip—there is a disconnect between the tooltip ? and the what it's referencing. @el-mapache @monfresh |
|
Blocked sounds harsh, just waiting on further comment from ryan 😄 |
|
on it! finishing up a couple high-priority tasks, then i will tackle this!
…On Tue, Jan 3, 2017 at 9:06 AM, Adam B ***@***.***> wrote:
Blocked sounds harsh, just waiting on further comment from ryan 😄
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#904 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AL-58UcGtNOWKFcXaUc4yjaTvvNEKCdLks5rOmQIgaJpZM4LW8Li>
.
|
|
Hello @rtwell -- do you have time to polish this off? Seems like the PR is getting a bit stale |
|
thanks for the reminder @jessieay |
|
@rtwell @RyanSibley @andrewhughey @esgoodman : Agree with either hyperlinking authenticator app or superimposing the question mark and making it slightly smaller so it doesn't break the sentences. Also, for the definition itself, rereading #1233, makes me wonder if we should identify a specific tool or company such as Google and Authy. Perhaps the definition itself should read as: "An authentication application is a mobile security application that generates sign-in passcodes even if you don't have an Internet connection or mobile service." |
|
@jeanninehunter @el-mapache We should just close this PR so we can all move on, I think. My request: merge this after
Then we create new issues to address:
|
|
I'm all for @esgoodman's proposal above. Expect new issues to resolve tooltip design, naming an auth app, and guidelines for tooltips. |
|
What's the status of this PR? Have Liz's changes been incorporated? Also, it looks like it need a rebase with master. |
|
@monfresh Yes, I did most of the work yesterday. Just cleaning up the specs |
|
Cool. I couldn't tell because there's only 1 commit 😄 |
4f4d565 to
26ddde4
Compare
**Why**: To ensure users understand what the app is, and how they can use it
**Why**: It is the easiest way to allow the presenter to have access to mehtods inside view helpers
26ddde4 to
03746f3
Compare
* Adds authenticator app tooltip **Why**: To ensure users understand what the app is, and how they can use it * Pass optional explicit view context to presenter **Why**: It is the easiest way to allow the presenter to have access to mehtods inside view helpers
* Adds authenticator app tooltip **Why**: To ensure users understand what the app is, and how they can use it * Pass optional explicit view context to presenter **Why**: It is the easiest way to allow the presenter to have access to mehtods inside view helpers
Why: To ensure users understand what the authenticator app is, and how they can
use it
EDIT: new visuals