Skip to content

LG-10660: Consolidate MFA setup controllers#9036

Merged
aduth merged 2 commits intomainfrom
aduth-lg-10660-consolidate-mfa-setup
Aug 22, 2023
Merged

LG-10660: Consolidate MFA setup controllers#9036
aduth merged 2 commits intomainfrom
aduth-lg-10660-consolidate-mfa-setup

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Aug 18, 2023

🎫 Ticket

LG-10660

🛠 Summary of changes

Updates links and updates capability of TwoFactorAuthenticationSetupController to handle both initial and additional MFA setups, with planned follow-on pull request to remove MfaSelectionController.

📜 Testing Plan

  1. Go to http://localhost:3000
  2. Create an account, up to "Authentication method setup"
  3. Observe no visual differences from main
  4. Set up an MFA method
  5. When prompted, choose to "Add another method"
  6. On the additional MFA setup screen, observe no visual differences from main

Also try a few variations:

👀 Screenshots

There should be no visual differences, aside from the URL in the additional MFA setup:

Before: /second_mfa_setup
After: /authentication_methods_setup

Screen Before After
Initial before-initial after-initial
Second before-second after-second

aduth added 2 commits August 18, 2023 13:05
changelog: Internal, Code Quality, Consolidate code paths for MFA setup
@aduth aduth force-pushed the aduth-lg-10660-consolidate-mfa-setup branch from 45f7474 to 2f6d433 Compare August 18, 2023 17:05
@aduth aduth marked this pull request as ready for review August 18, 2023 17:05
@aduth aduth requested a review from a team August 18, 2023 17:05
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Can confirm that it works as described.

@aduth aduth merged commit f86b678 into main Aug 22, 2023
@aduth aduth deleted the aduth-lg-10660-consolidate-mfa-setup branch August 22, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants