LG-10660: Consolidate MFA setup controllers#9036
Merged
Conversation
changelog: Internal, Code Quality, Consolidate code paths for MFA setup
45f7474 to
2f6d433
Compare
Contributor
kevinsmaster5
left a comment
There was a problem hiding this comment.
Code looks good to me. Can confirm that it works as described.
mdiarra3
approved these changes
Aug 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10660
🛠 Summary of changes
Updates links and updates capability of
TwoFactorAuthenticationSetupControllerto handle both initial and additional MFA setups, with planned follow-on pull request to removeMfaSelectionController.📜 Testing Plan
mainmainAlso try a few variations:
👀 Screenshots
There should be no visual differences, aside from the URL in the additional MFA setup:
Before:
/second_mfa_setupAfter:
/authentication_methods_setup