Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/jobs/usps_auth_token_refresh_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ def perform
analytics.idv_usps_auth_token_refresh_job_started

usps_proofer.retrieve_token!
rescue Faraday::TimeoutError, Faraday::ConnectionFailed => err
analytics.idv_usps_auth_token_refresh_job_network_error(
exception_class: err.class.name,
exception_message: err.message,
)
ensure
analytics.idv_usps_auth_token_refresh_job_completed
end
Expand Down
12 changes: 12 additions & 0 deletions app/services/analytics_events.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2414,6 +2414,18 @@ def idv_usps_auth_token_refresh_job_completed(**extra)
)
end

# Track when USPS auth token refresh job encounters a network error
# @param [String] exception_class
# @param [String] exception_message
def idv_usps_auth_token_refresh_job_network_error(exception_class:, exception_message:, **extra)
track_event(
'UspsAuthTokenRefreshJob: Network error',
exception_class: exception_class,
exception_message: exception_message,
**extra,
)
end

# Track when USPS auth token refresh job started
def idv_usps_auth_token_refresh_job_started(**extra)
track_event(
Expand Down
25 changes: 25 additions & 0 deletions spec/jobs/usps_auth_token_refresh_job_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -81,5 +81,30 @@
end.to raise_error
end
end

context 'auth request throws network error' do
[Faraday::TimeoutError, Faraday::ConnectionFailed].each do |err_class|
it "logs analytics without raising the #{err_class.name}" do
stub_network_error_request_token(
err_class.new('test error'),
)

expect(analytics).to receive(
:idv_usps_auth_token_refresh_job_started,
).once
expect(analytics).to receive(
:idv_usps_auth_token_refresh_job_network_error,
).with(
exception_class: err_class.name,
exception_message: 'test error',
).once
expect(analytics).to receive(
:idv_usps_auth_token_refresh_job_completed,
).once

subject.perform
end
end
end
end
end
4 changes: 4 additions & 0 deletions spec/support/usps_ipp_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ def stub_error_request_token
)
end

def stub_network_error_request_token(error)
stub_request(:post, %r{/oauth/authenticate}).to_raise(error)
end

def stub_request_facilities
stub_request(:post, %r{/ivs-ippaas-api/IPPRest/resources/rest/getIppFacilityList}).to_return(
status: 200,
Expand Down