Skip to content

LG-10656: Remove flow_session['address_edited'] #9027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 1 commit into from
Aug 24, 2023
Merged

LG-10656: Remove flow_session['address_edited'] #9027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/concerns/idv/verify_info_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def async_state_done(current_async_state)
state_id_number: pii[:state_id_number],
# todo: add other edited fields?
extra: {
address_edited: !!(idv_session.address_edited || flow_session['address_edited']),
address_edited: !!idv_session.address_edited,
address_line2_present: !pii[:address2].blank?,
pii_like_keypaths: [[:errors, :ssn], [:response_body, :first_name],
[:state_id, :state_id_jurisdiction]],
Expand Down
1 change: 0 additions & 1 deletion app/controllers/idv/address_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def profile_params

def capture_address_edited(result)
address_edited = result.to_h[:address_edited]
flow_session['address_edited'] = address_edited if address_edited
idv_session.address_edited = true if address_edited
end
end
Expand Down
6 changes: 0 additions & 6 deletions spec/controllers/idv/address_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@
expect(response).to redirect_to(idv_verify_info_url)
end

it 'sets address_edited in flow_session' do
expect do
put :update, params: params
end.to change { flow_session['address_edited'] }.from(nil).to eql(true)
end

it 'sets address_edited in idv_session' do
expect do
put :update, params: params
Expand Down