Skip to content

LG-10439 Remove the last barcode error writes to flow_session #8930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 1 commit into from
Aug 3, 2023
Merged

LG-10439 Remove the last barcode error writes to flow_session #8930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/controllers/concerns/idv/document_capture_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ def extract_pii_from_doc(user, response, store_in_session: false)
)

if defined?(flow_session) && defined?(idv_session) # hybrid mobile does not have idv_session
flow_session[:had_barcode_read_failure] = response.attention_with_barcode?
idv_session.had_barcode_read_failure = response.attention_with_barcode?
if store_in_session
flow_session[:pii_from_doc] ||= {}
Expand Down
1 change: 0 additions & 1 deletion app/controllers/idv/capture_doc_status_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ def pending_barcode_attention_confirmation?

def had_barcode_attention_result?
if session_result
flow_session[:had_barcode_attention_error] = session_result.attention_with_barcode?
idv_session.had_barcode_attention_error = session_result.attention_with_barcode?
end

Expand Down
7 changes: 0 additions & 7 deletions spec/controllers/idv/capture_doc_status_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@
it 'assigns flow session values as having received attention result' do
get :show

expect(flow_session[:had_barcode_attention_error]).to eq(true)
expect(controller.user_session[:idv][:had_barcode_attention_error]).to eq(true)
end
end
Expand All @@ -167,7 +166,6 @@
it 'assigns flow session values as having received attention result' do
get :show

expect(flow_session[:had_barcode_attention_error]).to eq(true)
expect(controller.user_session[:idv][:had_barcode_attention_error]).to eq(true)
end
end
Expand All @@ -183,15 +181,13 @@
end

before do
flow_session[:had_barcode_attention_error] = true
idv_session[:had_barcode_attention_error] = true
document_capture_session.update(ocr_confirmation_pending: false)
end

it 'assigns flow session values as not having received attention result' do
get :show

expect(flow_session[:had_barcode_attention_error]).to eq(false)
expect(controller.user_session[:idv][:had_barcode_attention_error]).to eq(false)
end
end
Expand All @@ -201,7 +197,6 @@
let(:flow_session) do
{
document_capture_session_uuid: document_capture_session.uuid,
had_barcode_attention_error: true,
}
end
let(:idv_session) do
Expand All @@ -224,7 +219,6 @@
it 'assigns flow session values as having received attention result' do
get :show

expect(flow_session[:had_barcode_attention_error]).to eq(true)
expect(controller.user_session[:idv][:had_barcode_attention_error]).to eq(true)
end
end
Expand All @@ -243,7 +237,6 @@
it 'assigns flow session values as having received attention result' do
get :show

expect(flow_session[:had_barcode_attention_error]).to eq(true)
expect(controller.user_session[:idv][:had_barcode_attention_error]).to eq(true)
end
end
Expand Down