LG-10373: Assistive technology reads "two" twice in authentication method setup#8923
Merged
LG-10373: Assistive technology reads "two" twice in authentication method setup#8923
Conversation
changelog: User-facing Improvements, accessibility, screen reader announces twice once
aduth
approved these changes
Aug 2, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Interesting that we didn't have this copy in the French & Spanish versions!
LGTM 👍
Contributor
Author
Yes, I also found that weird, but I'll take it 😅 |
mitchellhenke
approved these changes
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10373: Assistive technology reads "two" twice in authentication method setup
🛠 Summary of changes
This PR fixes a bug where "two" is read twice by a screen reader. It will now be announced once.
📜 Testing Plan
With a screen reader of your choice
After logging on to localhost:3000
👀 Screenshots
Screen.Recording.2023-08-02.at.1.44.43.PM.mov