Skip to content

Remove sm-left-align custom CSS utility class#8917

Merged
aduth merged 1 commit intomainfrom
aduth-rm-sm-left-align
Aug 2, 2023
Merged

Remove sm-left-align custom CSS utility class#8917
aduth merged 1 commit intomainfrom
aduth-rm-sm-left-align

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Aug 1, 2023

🛠 Summary of changes

Removes the sm-left-align CSS utility class.

Why?

  • Reduce size of application stylesheet
  • Remove legacy references to "sm" as referring to BassCSS breakpoints, now standardized toward "tablet" USWDS breakpoint token
  • Simplify usage leveraging left text alignment as default behavior

Recommend reviewing with whitespace changes hidden: https://github.com/18F/identity-idp/pull/8917/files?w=1

📜 Testing Plan

Verify no regressions in the affected usage:

  1. Account management page header
  2. Authenticating with a partner when already signed-in

👀 Screenshots

There's not expected to be any visual effect of these changes. Below are screenshots noting the affected usage, which should be unaffected.

Screen Shot 2023-08-01 at 3 16 16 PM

Screen Shot 2023-08-01 at 3 16 19 PM

Screen Shot 2023-08-01 at 3 20 11 PM

changelog: Internal, Performance, Reduce size of application stylesheet
@aduth aduth merged commit 096da80 into main Aug 2, 2023
@aduth aduth deleted the aduth-rm-sm-left-align branch August 2, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants