Skip to content

LG-10479 FSM/SSN - Check redirect for SSN Step #8913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gina-yamada merged 6 commits into from
Aug 2, 2023
Merged

LG-10479 FSM/SSN - Check redirect for SSN Step #8913

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68bb90d
Mark fsm ssn step as complete if ssn is on pii_from_user
gina-yamada Aug 1, 2023
246c318
changelog: Upcoming Features, In-person proofing, Mark fsm ssn step c…
gina-yamada Aug 1, 2023
704a5a0
Merge branch 'main' of github.com:18F/identity-idp into gina/lg-10479…
gina-yamada Aug 1, 2023
793adf0
Merge branch 'main' of github.com:18F/identity-idp into gina/lg-10479…
gina-yamada Aug 2, 2023
06de8e2
Merge branch 'main' of github.com:18F/identity-idp into gina/lg-10479…
gina-yamada Aug 2, 2023
f21f08b
Merge branch 'main' of github.com:18F/identity-idp into gina/lg-10479…
gina-yamada Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/controllers/concerns/idv_step_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ def flow_path
private

def confirm_ssn_step_complete
if IdentityConfig.store.in_person_ssn_info_controller_enabled
# mark ssn step as complete for FSM
Copy link
Contributor

@svalexander svalexander Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the comment read for non-fsm rather than fsm?

Copy link
Contributor Author

@gina-yamada gina-yamada Aug 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svalexander Although we are in the non-FSM step- I am actually marking the FSM step as complete. Here is my thinking (let me know your thoughts please)...

When the users manually changes the url to the FSM ssn step (because they did not visit it, it is not getting marked as complete) so they are able to visit it (not expected behavior) rather than being redirected back to Verify (expected behavior) because it is complete. If we mark it as complete (we have the data- they just got it on the new flow)- they will be redirect to Verify Info- and will have to get to SSN by using the Update button.

This will need to get removed in your delete PR.

Copy link
Contributor

@svalexander svalexander Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh i see what you're saying, ok the comment makes sense then

flow_session['Idv::Steps::InPerson::SsnStep'] = true if flow_session.dig(:pii_from_user, :ssn)
end
return if pii.present? && pii[:ssn].present?
redirect_to prev_url
end
Expand Down