Conversation
changelog: User-Facing Improvements, Identity Verification, update copy for alert shown when user retries failed phone number
amirbey
changed the title
config/locales/idv/fr.yml
Outdated
| gpo_alert_html: Si vous n’avez pas <strong>d’autre</strong> numéro de téléphone | ||
| à essayer, %{link_html}. | ||
| gpo_alert_html: Essayez un <strong>autre</strong> numéro ou %{link_html}. | ||
| gpo_verify_link: vérifiez plutôt par courrier |
Contributor
There was a problem hiding this comment.
The other translations with this tag just say "verify by mail". Do we want to update this one to match? It says "verify by mail instead".
Suggested change
| gpo_verify_link: vérifiez plutôt par courrier | |
| gpo_verify_link: vérifiez par courrier |
Contributor
Author
There was a problem hiding this comment.
English also says "instead" but it's not part of the link. However, Spanish does not. Because of the way the words fall between translations, "instead" can be de-grouped from the link in English.
@artfulaction - thoughts? 🤔
Contributor
There was a problem hiding this comment.
Let's remove "instead" from all (including English) to keep it consistent. Thanks for catching that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10511
🛠 Summary of changes
Update copy for alert that notifies users they are retrying a failed number during IDV phone step.
📜 Testing Plan
👀 Screenshots
Before:
After: