Conversation
changelog: Internal, Linting, Upgrade Rubocop to latest version
mitchellhenke
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Upgrades Rubocop to the latest version.
I noticed in #8909 that my local precommit Rubocop check was flagging some preexisting issues in
spec/presenters/webauthn_setup_presenter_spec.rb. It turns out that newer versions of Rubocop have some improvements for catching unintended issues:The newer version would have also started enforcing anonymous arguments forwarding, but I chose to disable this as a stylistic preference.
For example, this:
identity-idp/spec/support/features/session_helper.rb
Lines 28 to 29 in f3d1a46
...would have been enforced as:
📜 Testing Plan
bundlerubocop