LG-10477: Add checks for WebAuthn browser support#8904
Merged
Conversation
changelog: Bug Fixes, Security Key, Fix security key enrollment in Firefox
aduth
commented
Jul 31, 2023
kevinsmaster5
approved these changes
Aug 1, 2023
Contributor
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
Looks good to me. Tested and validated locally MacOS Firefox according to testing method above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10477
Fixes #8877
🛠 Summary of changes
Updates WebAuthn enrollment logic to gracefully handle absence of WebAuthn APIs not implemented in all browsers, notably fixing an issue where it is not currently possible to add a Security Key in Firefox.
Recommend reviewing with whitespace changes hidden: https://github.com/18F/identity-idp/pull/8904/files?w=1
📜 Testing Plan
👀 Screenshots