LG-10385 Add new columns for in-person proofing pending#8899
Merged
Conversation
added a column to check if a user has a pending in_person_enrollment before their profile receives the in_person_verification_pending_at timestamp. this field is to replace the ProofingComponent 'document_check' for in person enrollments
changelog: Internal, IdV IPP, add columns in profile for in_person_proofing_pending
Contributor
|
👍🏾 |
kbighorse
approved these changes
Jul 28, 2023
|
|
||
| def change | ||
| add_column :profiles, :in_person_verification_pending_at, :datetime | ||
| add_index :profiles, :in_person_verification_pending_at, algorithm: :concurrently |
Contributor
There was a problem hiding this comment.
Do we plan to query by this column in the future?
Contributor
Author
There was a problem hiding this comment.
Not that much. I'll remove the index. If we do need it we can add it back.
removed in_person_enrollment_pending_at as it is not needed. We can use user.establishing_in_person_enrollment to check for enrollments
Contributor
|
Are we sure that having a single |
Contributor
Author
|
There's also a foreign_key for profiles so we can create a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10382
🛠 Summary of changes
Created two new columns in IdV user's profile for in person verification:
in_person_verification_pending_atis a timestamp for when a profile gets "deactivated" for in person verification.in_person_enrollment_pending_atis a timestamp for when a user has a pending enrollment. This column is meant topending_profile&.proofing_components&.[]('document_check') == Idp::Constants::Vendors::USPSfor an in_person_enrollment and make it more explicit in a user's profile.