LG-9459: Accessing phone error screens should redirect you if you haven't entered your phone yet

[amirbey]

🎫 Ticket

LG-9459

🛠 Summary of changes

Add before action to phone_errors controller to verify that a user has submitted a phone number before rendering error page.

📜 Testing Plan

• start identity verification and complete any number steps before phone verification
• observe the current step (ie: welcome, agreement, doc_auth, etc.)
• visit a phone errors page (ie: http://example.com/verify/phone/errors/warning in the browser)
• verify being redirected to the step observed above

repeat the steps ensuring that all phone errors pages have been tested:
http://example.com/verify/phone/errors/warning
http://example.com/verify/phone/errors/failure
http://example.com/verify/phone/errors/jobfail

[soniaconnolly]

Interesting idea to use RateLimiter! We've been checking idv_session for statuses like this. Do we want to adopt RateLimiter as a new pattern?

[amirbey]

you're right 😅 ... i have reimplemented this using the idv_session ...thanks @soniaconnolly 👍🏿

[soniaconnolly]

Implementation looks good! Some stray code left over.

[soniaconnolly]

LGTM!