Fix 500 Error: Create Account with Suspended User Email Using "+" sign#8892
Merged
olatifflexion merged 4 commits intomainfrom Jul 28, 2023
Merged
Fix 500 Error: Create Account with Suspended User Email Using "+" sign#8892olatifflexion merged 4 commits intomainfrom
olatifflexion merged 4 commits intomainfrom
Conversation
Contributor
olatifflexion
commented
Jul 28, 2023
olatifflexion
commented
[skip changelog]
zachmargolis
approved these changes
Jul 28, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, can we please add a spec for this? I suspect the "confirm now" button may be untested but this seems like a good thing to add a regression spec for
jc-gsa
reviewed
Jul 28, 2023
Contributor
jc-gsa
left a comment
jc-gsa
left a comment
There was a problem hiding this comment.
There's another instance you may want to fix as well, as the line of code appears in two locations:
identity-idp/app/views/sign_up/emails/show.html.erb
identity-idp/app/views/users/emails/verify.html.erb
n1zyy
approved these changes
Jul 28, 2023
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
Approving because this fixes a nasty bug, but we might want to do more.
zachmargolis
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.