LG-10439 Start moving had_barcode_attention_error to idv_session#8889
Merged
LG-10439 Start moving had_barcode_attention_error to idv_session#8889
had_barcode_attention_error to idv_session#8889Conversation
jmhooper
changed the title
had_barcode_attention_error to Idv::Sessionhad_barcode_attention_error to idv_session
Contributor
There was a problem hiding this comment.
Since you just set it, can you start returning idv_session.had_barcode_attention_error here? Or, since the value is only read here as far as I can tell, do we even need to add it to idv_session? Can we just return session_result.attention_with_barcode?
Contributor
There was a problem hiding this comment.
Nevermind, I worked through it after I commented... It's polling, so it might set it in one request and read it later.
We are working to retire `flow_session` as part of retiring FSM and restoring the back button functionality. This commit starts to move one of the properties, `had_barcode_attention_error`, into `idv_session`. Another commit will be necessary to start reading from the `idv_session` and then a final commit to stop writing to `flow_session`. [skip changelog]
jmhooper
force-pushed
the
jmhooper-move-had-barcode-attention-errors
branch
from
e45c953 to
e6b2c27
Compare
jmhooper
added a commit
that referenced
this pull request
Aug 1, 2023
We are working on removing the flags that indicate a bardcode read error from the `flow_session` and adding them to `idv_session` instead. The work to write the values to `idv_session` was handled in #8881 and #8889. That has been deployed so it is not safe to start reading the values from `idv_session`. A future commit will stop writing them to `flow_session`. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Aug 2, 2023
We are working on removing the flags that indicate a barcode read error from the `flow_session` and adding them to `idv_session` instead. The work to write the values to `idv_session` was handled in #8881 and #8889. That has been deployed so it is not safe to start reading the values from `idv_session`. A future commit will stop writing them to `flow_session`. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are working to retire
flow_sessionas part of retiring FSM and restoring the back button functionality.This commit starts to move one of the properties,
had_barcode_attention_error, intoidv_session. Another commit will be necessary to start reading from theidv_sessionand then a final commit to stop writing toflow_session.