Add "count distinct" option to CloudWatch query script#8887
Merged
Conversation
changelog: Internal, Log Querying, Add count distinct option to log querying script
See: #8887 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Handle uniqueness by value set See: - #8887 (comment) - #8887 (comment)
aduth
changed the title
aduth
changed the title
zachmargolis
approved these changes
Jul 28, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM one small comment
aduth
added a commit
that referenced
this pull request
Jul 31, 2023
See: #8887 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Supports LG-7708
🛠 Summary of changes
Adds new
--count-distinctoption tobin/query-cloudwatchto help produce a total distinct count from a query that may need to be stitched together with the--completefunctionality.📜 Testing Plan
Example usage: