LG-10252 Start renaming throttled routes#8886
Merged
soniaconnolly merged 11 commits intomainfrom Jul 31, 2023
Merged
Conversation
Co-authored-by: John Maxwell <john.maxwell@gsa.gov>
…renaming-throttled-routes
matthinz
reviewed
Jul 28, 2023
config/routes.rb
Outdated
Comment on lines
370
to
371
| get '/session/errors/throttled' => 'session_errors#throttled' | ||
| get '/session/errors/rate_limited' => 'session_errors#throttled' |
Contributor
There was a problem hiding this comment.
You can probably go ahead and rename the action in SessionErrorsController as well?
Suggested change
| get '/session/errors/throttled' => 'session_errors#throttled' | |
| get '/session/errors/rate_limited' => 'session_errors#throttled' | |
| get '/session/errors/throttled' => 'session_errors#rate_limited' | |
| get '/session/errors/rate_limited' => 'session_errors#rate_limited' |
Contributor
Author
There was a problem hiding this comment.
Good idea. bca4111 There are also some javascript references to 'throttled' I'm not sure how to change. Maybe we can take a look on Monday.
The old route is still there and will be changed to a redirect in a future commit.
…MITED" This reverts commit 9a94a4c.
…renaming-throttled-routes
Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
matthinz
approved these changes
Jul 31, 2023
soniaconnolly
commented
Jul 31, 2023
Comment on lines
92
to
+94
| this.trackEvent('IdV: Link sent capture doc polling complete', { | ||
| isCancelled: result === ResultType.CANCELLED, | ||
| isThrottled: result === ResultType.THROTTLED, | ||
| isRateLimited: result === ResultType.RATE_LIMITED, |
Contributor
Author
There was a problem hiding this comment.
@R-Ornelas one more throttle-related analytics change. 'IdV: Link sent capture doc polling complete' argument is now isRateLimited, formerly isThrottled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10252
🛠 Summary of changes
based_on_throttletobased_on_limiterin SessionErrorsController📜 Testing Plan
Automated tests.
Create an account, navigate to
/verify/session/errors/rate_limited, expect it to look just like/verify/session/errors/throttled