Merged
Conversation
Add skip_upload and skip_hybrid_handoff inputs in document-capture-welcome. A future commit will remove skip_upload [skip changelog]
Contributor
Author
|
#8885 will be the cleanup PR for this one, ready to merge after this is deployed. |
jmhooper
approved these changes
Jul 27, 2023
|
|
||
| def update | ||
| skip_to_capture if params[:skip_upload] | ||
| skip_to_capture if params[:skip_hybrid_handoff] || params[:skip_upload] |
Contributor
There was a problem hiding this comment.
What do you think of changing the new parameter name to is_mobile or mobile_device_detected or something like that?
Contributor
Author
There was a problem hiding this comment.
I think I want to keep it as skip_hybrid_handoff. At this moment it makes slighly more sense to me to think of it as the client saying "I don't need to see the hybrid handoff screen" rather than the server saying "you're probably a mobile device with a camera, so I won't show you the hybrid handoff screen".
matthinz
added a commit
that referenced
this pull request
Jul 28, 2023
The process of renaming skip_upload to skip_hybrid_handoff was started in #8884. This completes the job. [skip changelog]
matthinz
added a commit
that referenced
this pull request
Aug 1, 2023
The process of renaming skip_upload to skip_hybrid_handoff was started in #8884. This completes the job. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Kind of related to LG-10402
🛠 Summary of changes
We've already renamed "upload" step of IdV to "hybrid handoff". This PR begins the process of renaming an internal parameter from
skip_uploadtoskip_hybrid_handoff. To handle the 50/50 state during deployment, we'll temporarily send bothskip_uploadandskip_hybrid_handoffand let our controllers accept both. A future PR (to be merged after this is deployed) will fully remove support forskip_upload.This PR also adds some test coverage for what happens when
skip_uploadorskip_hybrid_handoffis present–the details of this will change with work on LG-10402, but I wanted to capture it as it is here.Also, since we're in the process of A/B testing a new unified "Getting Started" screen, this PR involves the same changes made to
AgreementControllerandGettingStartedController.