Skip to content

LG-10441: Dont allow Skipping when Webauthn Platform#8867

Merged
mdiarra3 merged 5 commits intomainfrom
LG-10441-skip-required-platform-auth
Aug 2, 2023
Merged

LG-10441: Dont allow Skipping when Webauthn Platform#8867
mdiarra3 merged 5 commits intomainfrom
LG-10441-skip-required-platform-auth

Conversation

@mdiarra3
Copy link
Contributor

🎫 Ticket

Dont allow Skip when second MFA is required for platform auth

🛠 Summary of changes

This makes it so when users select Platform Auth as their only option, they arent able to hit continue on the second mfa page until they select an additional option.

👀 Screenshots

Now when u dont select an option you get below.
Screen Shot 2023-07-26 at 11 44 11 AM

…ting continue when platform auth requires second option
@mdiarra3 mdiarra3 requested a review from a team July 26, 2023 15:45
Copy link
Contributor

@jc-gsa jc-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an additional flow that does not appear to be handled, perhaps this could be another ticket. If the user registers, confirms their account, then adds webauthn platform and subsequently closes their browser they'll have a valid account with 1 auth method. They can then login successfully and will not be requested to add another method, thereby "skipping".

@aduth
Copy link
Contributor

aduth commented Jul 27, 2023

There's an additional flow that does not appear to be handled, perhaps this could be another ticket. If the user registers, confirms their account, then adds webauthn platform and subsequently closes their browser they'll have a valid account with 1 auth method. They can then login successfully and will not be requested to add another method, thereby "skipping".

Yeah, that's technically possible. I recall it coming up in a team discussion and we'd decided this is more a restriction in the user's interest of the happy path flow, but that it didn't need to be lock-tight. Or at least that enforcing it universally didn't seem to have enough value for the effort involved. It's worth surfacing in a team discussion if you think we should revisit this, though I'd agree it'd be a separate ticket.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mdiarra3 mdiarra3 merged commit 6fe145b into main Aug 2, 2023
@mdiarra3 mdiarra3 deleted the LG-10441-skip-required-platform-auth branch August 2, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants