LG-9837, LG-10380 - Add confirm password to reset & edit#8862
Merged
Conversation
…email_language_spec
… users/user_edit_spec
changelog: User-Facing Improvements, Authentication, Add password confirmation to reset password
aduth
reviewed
Jul 26, 2023
jc-gsa
force-pushed
the
LG-9837-add-password-confirmation-to-reset-password
branch
from
263a0cb to
2640dea
Compare
mdiarra3
approved these changes
Jul 27, 2023
Contributor
mdiarra3
left a comment
mdiarra3
left a comment
There was a problem hiding this comment.
Tested this and working fine for both reset and edit password
aduth
approved these changes
Jul 27, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Minor comment, but LGTM otherwise 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Tickets
LG-9837
LG-10380
🛠 Summary of changes
This adds the password confirmation component to two separate flows: "reset password" and "edit password".
📜 Testing Plan
Verify expected behavior of the password confirmation component at two separate locations:
Reset password: Click "Forgot your password" link at the login page to access
/users/password/new.Edit password. Login to your account then click "Edit password" or access the
/manage/password.