Consolidate in person Proofing reads and writes into methods.#8856
Merged
Consolidate in person Proofing reads and writes into methods.#8856
Conversation
kbighorse
changed the title
changelog: Internal, In-person proofing, refactor in-proofing reads and writes
jmhooper
reviewed
Jul 26, 2023
jmhooper
reviewed
Jul 26, 2023
… use it in gpo verify form
kbighorse
commented
Jul 27, 2023
|
|
||
| def in_person_enrollment? | ||
| ProofingComponent.find_by(user: current_user)&.document_check == Idp::Constants::Vendors::USPS | ||
| current_user.proofing_component&.document_check == Idp::Constants::Vendors::USPS |
Contributor
Author
There was a problem hiding this comment.
do this here rather in User class for the time being
kbighorse
commented
Jul 27, 2023
| transaction do | ||
| UspsInPersonProofing::EnrollmentHelper.schedule_in_person_enrollment(user, pii) | ||
| deactivate(:in_person_verification_pending) | ||
| end |
Contributor
Author
There was a problem hiding this comment.
make sure these both succeed or fail together
kbighorse
deleted the
LG-10381-Consolidate-in-person-Proofing-reads-and-writes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10381 Consolidate in person Proofing reads and writes into methods.
🛠 Summary of changes
Write a brief description of what you changed.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.