Add hostdata metadata to review apps#8854
Merged
mitchellhenke merged 5 commits intomainfrom Jul 25, 2023
Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/add-hostdata-to-review-apps
branch
from
fbe9642 to
bb4cde5
Compare
changelog: Internal, Continuous Integration, Add hostdata metadata to review apps
mitchellhenke
force-pushed
the
mitchellhenke/add-hostdata-to-review-apps
branch
from
bb4cde5 to
82f46e5
Compare
mitchellhenke
force-pushed
the
mitchellhenke/add-hostdata-to-review-apps
branch
from
18971cf to
96698b1
Compare
zachmargolis
approved these changes
Jul 25, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM pending hostdata gem pr
added 2 commits
July 25, 2023 11:51
Gemfile.lock
Outdated
Contributor
There was a problem hiding this comment.
the tag is v3.4.3 but this says 3.4.2 ... which one is right?
Contributor
Author
There was a problem hiding this comment.
Hm, it looks like 3.4.2 was tagged but the version stayed at 3.4.1 from 18F/identity-hostdata#36, so I might just force tag over 3.4.2?
mitchellhenke
force-pushed
the
mitchellhenke/add-hostdata-to-review-apps
branch
from
7d3a6d6 to
7521cf0
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
A few feature flags and configuration items depend on these values, and this brings review apps closer to being in-line with sandboxes. Depends on 18F/identity-hostdata#37