Skip to content

LG-10362: New Image Capture Page Language#8851

Merged
charleyf merged 8 commits intomainfrom
charley/lg-10362/new-image-capture-target-language
Jul 27, 2023
Merged

LG-10362: New Image Capture Page Language#8851
charleyf merged 8 commits intomainfrom
charley/lg-10362/new-image-capture-target-language

Conversation

@charleyf
Copy link
Copy Markdown
Contributor

@charleyf charleyf commented Jul 25, 2023

🎫 Ticket

https://cm-jira.usa.gov/browse/LG-10362

🛠 Summary of changes

This PR updates three pieces of text on the image capture page:

  1. The page header at the top
  2. The sentence immediately below the page header
  3. The text inside the tap-targets

📜 Testing Plan

The testing plan is basically: Go look at the document upload page, check that the new text appears. [ Edit: Also check that the text/formatting in the tap-target looks good on mobile and desktop because we changed the font size. ]

  • Log in/create an account in your local instance using English as the language.
  • Type this into your address bar to start the verify process: http://localhost:3000/verify/
  • Click through a few pages, then choose to upload the photos from your computer (since it's faster to do this).
  • When you get to the page with the upload targets for the front/back of the ID
    • Verify that the English page header matches the design and text in ticket (linked above)
    • Verify that the text directly under the header matches the design and text in ticket (linked above).
    • Verify that the English text inside the front upload target matches the design and text in ticket (linked above).
    • Verify that the English text inside the back upload target matches the design and text in ticket (linked above).
  • Switch your language to Spanish by changing the URL.
    • When looking at the document upload page in English your URL bar will look like this: http://localhost:3000/en/verify/document_capture
    • Change to Spanish by swapping the en for es like this: http://localhost:3000/es/verify/document_capture
    • Verify that the Spanish page header matches the design and text in ticket (linked above)
    • Verify that the text directly under the header matches the text in ticket (linked above).
    • Verify that the Spanish text inside the front upload target matches the text in ticket (linked above).
    • Verify that the Spanish text inside the back upload target matches the text in ticket (linked above).
  • Switch your language to French by changing the URL.
    • Change to French: http://localhost:3000/fr/verify/document_capture
    • Verify that the French page header matches the design and text in ticket (linked above)
    • Verify that the text directly under the header matches the text in ticket (linked above).
    • Verify that the French text inside the front upload target matches the text in ticket (linked above).
    • Verify that the French text inside the back upload target matches the text in ticket (linked above).

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

English:

localhost_3000_verify_document_capture(My Screen)

Spanish:

localhost_3000_es_verify_document_capture(My Screen)

French:

localhost_3000_fr_verify_document_capture(My Screen)

@eileen-nava eileen-nava requested review from a team, eileen-nava and night-jellyfish and removed request for a team and night-jellyfish July 25, 2023 15:53
@charleyf charleyf requested a review from kellular July 25, 2023 20:01
Copy link
Copy Markdown

@kellular kellular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include screenshots of what this page looks like on mobile too? I can't tell from the file what text size the "Front/Back of your..." copy is, but it looks a bit large on the desktop views

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kellular Putting the screenshots here so we can use the threading to discuss. I did also want to mention that this PR changes from all uppercase like "FRONT" to mixed case as I'm seeing in the designs.

iOS - Chrome

IMG_9669

iOS - Safari

IMG_9670

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Yep, the tap target copy should be sentence case like you have it here.

Is the desktop screen size using an h1 for the tap target copy?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the desktop in Chrome

<!-- The page heading -->
<!-- The font size is set to 1.75rem which ends up being computed to a font size of 28px for my browser -->
<h1 class="page-heading">Add photos of your ID</h1>

<!-- The text in the tap target -->
<!-- The font size is set to 1.625rem which ends up being computed to a font size of 26px for my browser -->
<strong class="usa-file-input__banner-text">Front of your driver’s license or state ID</strong>

Copy link
Copy Markdown
Contributor Author

@charleyf charleyf Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easy to resize this text, happy to give you a live demo of various sizes. Here's some screenshots with different font sizes I tried.

Tap-Target Text 1.25rem
rem-1 25

Tap-Target Text 1.5rem
rem-1 5

Tap-Target Text As Is 1.625rem
as-is-rem-1 625

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for all the screenshots! Could we make the tap target text an h2 for both desktop and mobile? I think that's 1.375rem and 1.25rem respectively

Copy link
Copy Markdown
Contributor Author

@charleyf charleyf Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made that change (commit link). The size of that text is now directly inherited from the h2 sizing. Here's what it looks like

Desktop
Screenshot 2023-07-26 at 15 05 04

Mobile
Screenshot 2023-07-26 at 15 04 46

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! And just confirming - the tap target on desktop screen sizes will still include the "Drag file here or choose from folder" text right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! That happened because I was using dev-tools on my desktop to view this and forgot to refresh the page. Here's what it looks like on my desktop right now
Screenshot 2023-07-26 at 15 25 23

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for confirming! This LGTM

@kellular kellular self-requested a review July 26, 2023 19:27
@charleyf charleyf merged commit 8403732 into main Jul 27, 2023
@charleyf charleyf deleted the charley/lg-10362/new-image-capture-target-language branch July 27, 2023 13:32
@amirbey amirbey mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants