LG-10362: New Image Capture Page Language#8851
Conversation
There was a problem hiding this comment.
@kellular Putting the screenshots here so we can use the threading to discuss. I did also want to mention that this PR changes from all uppercase like "FRONT" to mixed case as I'm seeing in the designs.
iOS - Chrome
iOS - Safari
There was a problem hiding this comment.
Thank you! Yep, the tap target copy should be sentence case like you have it here.
Is the desktop screen size using an h1 for the tap target copy?
There was a problem hiding this comment.
On the desktop in Chrome
<!-- The page heading -->
<!-- The font size is set to 1.75rem which ends up being computed to a font size of 28px for my browser -->
<h1 class="page-heading">Add photos of your ID</h1>
<!-- The text in the tap target -->
<!-- The font size is set to 1.625rem which ends up being computed to a font size of 26px for my browser -->
<strong class="usa-file-input__banner-text">Front of your driver’s license or state ID</strong>There was a problem hiding this comment.
thank you for all the screenshots! Could we make the tap target text an h2 for both desktop and mobile? I think that's 1.375rem and 1.25rem respectively
There was a problem hiding this comment.
Made that change (commit link). The size of that text is now directly inherited from the h2 sizing. Here's what it looks like
There was a problem hiding this comment.
Looks great! And just confirming - the tap target on desktop screen sizes will still include the "Drag file here or choose from folder" text right?
There was a problem hiding this comment.
great, thanks for confirming! This LGTM






🎫 Ticket
https://cm-jira.usa.gov/browse/LG-10362
🛠 Summary of changes
This PR updates three pieces of text on the image capture page:
📜 Testing Plan
The testing plan is basically: Go look at the document upload page, check that the new text appears. [ Edit: Also check that the text/formatting in the tap-target looks good on mobile and desktop because we changed the font size. ]
http://localhost:3000/verify/http://localhost:3000/en/verify/document_captureenforeslike this:http://localhost:3000/es/verify/document_capturehttp://localhost:3000/fr/verify/document_capture👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
English:
Spanish:
French: