Conversation
Contributor
Author
This is a lie. I am marking this do not merge until #8821 is deployed to production and we have run the backfill job. |
Contributor
Author
|
I also need to go through and update some specs that include the |
soniaconnolly
approved these changes
Jul 26, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM (have not tried it locally). Couple of queries.
…er is fraud review pending We recently changed the way we determine if a user is in fraud review. The change added a `fraud_pending_reason` column to a user to mark that they might require fraud review after address verification. Users who verify their address by phone are marked fraud review pending right away. Users who verify their address by mail are only marked fraud review pending after they enter their OTP. To allow us to change the way we manage the fraud timestamps we moved the reads that determine if a user is in fraud review to look for the presence of `fraud_pending_reason`. This maintained legacy behavior while allowing us to adjust writes on `fraud_review_pending_at` and backfilling. Now that those reads and backfills are complete we can switch reads back to `fraud_review_pending_at`. [skip changelog]
jmhooper
force-pushed
the
jmhooper-start-using-fraud-pending-at-again
branch
from
5fa13a5 to
bf9d25b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently changed the way we determine if a user is in fraud review. The change added a
fraud_pending_reasoncolumn to a user to mark that they might require fraud review after address verification.Users who verify their address by phone are marked fraud review pending right away. Users who verify their address by mail are only marked fraud review pending after they enter their OTP.
To allow us to change the way we manage the fraud timestamps we moved the reads that determine if a user is in fraud review to look for the presence of
fraud_pending_reason. This maintained legacy behavior while allowing us to adjust writes onfraud_review_pending_atand backfilling.Now that those reads and backfills are complete we can switch reads back to
fraud_review_pending_at.