Skip to content

LG-9853 ssn add update route#8844

Merged
svalexander merged 6 commits intomainfrom
shannon/lg-9853-ssn-add-update-route
Jul 25, 2023
Merged

LG-9853 ssn add update route#8844
svalexander merged 6 commits intomainfrom
shannon/lg-9853-ssn-add-update-route

Conversation

@svalexander
Copy link
Contributor

@svalexander svalexander commented Jul 24, 2023

🎫 Ticket

LG-9853

🛠 Summary of changes

Add tests for update route

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Run spec and make sure all tests pass

@svalexander svalexander requested review from a team and gina-yamada July 24, 2023 21:19
@svalexander svalexander changed the title Shannon/lg 9853 ssn add update route LG-9853 ssn add update route Jul 25, 2023
Copy link
Contributor

@tomas-nava tomas-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve!

One thing I did notice, unrelated to this specific PR:

If I'm on the verify info page, and manually enter the url for the FSM version of the SSN page (in_person/ssn), it loads that page rather than redirecting me back to the verify info page. The redirect works if I manually enter the url for the non_FSM version of the SSN page (in_person_proofing/ssn)

}
end

it 'sends analytics_visited event' do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it 'sends analytics_visited event' do
it 'sends analytics_submitted event' do

@svalexander svalexander merged commit 7c3e03f into main Jul 25, 2023
@svalexander svalexander deleted the shannon/lg-9853-ssn-add-update-route branch July 25, 2023 18:32
@svalexander
Copy link
Contributor Author

approve!

One thing I did notice, unrelated to this specific PR:

If I'm on the verify info page, and manually enter the url for the FSM version of the SSN page (in_person/ssn), it loads that page rather than redirecting me back to the verify info page. The redirect works if I manually enter the url for the non_FSM version of the SSN page (in_person_proofing/ssn)

checking that i understand:
it loads the ssn page instead of staying on verify info when you manually enter /ssn?

@tomas-nava
Copy link
Contributor

it loads the ssn page instead of staying on verify info when you manually enter /ssn?

yeah, feel free to ping me and I can demonstrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants