Skip to content

Show troubleshooting options consistently across all MFA verification#8834

Merged
aduth merged 6 commits intomainfrom
aduth-lg-10286-mfa-troubleshooting
Aug 1, 2023
Merged

Show troubleshooting options consistently across all MFA verification#8834
aduth merged 6 commits intomainfrom
aduth-lg-10286-mfa-troubleshooting

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 21, 2023

🎫 Ticket

Related to LG-10286

🛠 Summary of changes

Updates MFA verification to use a common troubleshooting options module at the bottom of the page, so that users aren't confused by differing content layouts between MFA methods. You should be able to see the adoption of consistently pretty obviously by a cursory glance of the Before/After screenshots below.

📜 Testing Plan

  1. Go to http://localhost:3000
  2. Sign in
  3. When prompted for MFA, observe troubleshooting options
    • In most cases, this should be consistently "Choose another authentication method" and "Learn more about authentication options", though some pages have specific additional help (e.g. phone "I didn't receive my one-time code", or restrictions such as PIV-only or AAL2-phishing-resistant, which currently still show the appropriate option, but will be changed as part of future work in LG-10286).

👀 Screenshots

Method Before After
Backup codes before-backup after-backup
Face/Touch Unlock before-ft after-ft
Personal Key before-personal-key after-personal-key
Phone before-phone after-phone
PIV before-piv after-piv
Security Key before-security-key after-security-key
Authentication App before-totp after-totp

@aduth aduth requested a review from a team July 21, 2023 19:12
Comment on lines 416 to 424
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this and the spec/features/users/sign_in_spec.rb are another case of not_to assertions passing without any actual relevance to the page. I'm assuming earlier iterations of these screens may have had mentions of specific MFAs, rather than leading back to the MFA selection screen via "Choose another authentication method". It only became a problem when we removed the string.

Comment on lines 385 to 414
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At one point it seems that we may have prevented the user from returning to the MFA selection during account setup during HSPD12, but as above, the to_not wasn't doing anything meaningful here, and we've shown an option to return to the MFA selection for at least a while now. But the MFA selection does prevent the user from choosing anything other than PIV.

Screen Shot 2023-07-24 at 8 34 35 AM
Screen Shot 2023-07-24 at 8 34 41 AM

Copy link
Contributor

@jmdembe jmdembe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM

aduth added 6 commits August 1, 2023 09:58
changelog: User-Facing Enhancements, MFA Verification, Show consistent troubleshooting options on MFA verification
changelog: User-Facing Improvements, MFA Verification, Show consistent troubleshooting options on MFA verification
@aduth aduth force-pushed the aduth-lg-10286-mfa-troubleshooting branch from 50c9149 to 0d2968f Compare August 1, 2023 14:19
@aduth aduth merged commit f832b25 into main Aug 1, 2023
@aduth aduth deleted the aduth-lg-10286-mfa-troubleshooting branch August 1, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants