Render non-passkey-restricted WebAuthn input as visible#8830
Merged
Conversation
changelog: User-Facing Enhancements, MFA Methods, Avoid flickering layout for WebAuthn options on authenticator selection
changelog: User-Facing Improvements, MFA Methods, Avoid flickering layout for WebAuthn options on authenticator selection
mitchellhenke
approved these changes
Jul 26, 2023
aduth
commented
Jul 26, 2023
| if platform? && passkey_supported_only? | ||
| { hidden: true } | ||
| else | ||
| { class: 'js' } |
Contributor
Author
There was a problem hiding this comment.
I probably should have clarified how this is working: We have .js and .no-js class styles which hide the content in JavaScript disabled / enabled environments respectively (applied and toggled in the base layout). So by adding js as a class here, it's how we hide the content for browsers with JavaScript disabled.
Contributor
|
I'm having trouble validating using the steps above. Step 9: Face or touch unlock is not visible given config is added, JavaScript is reenabled. I am normally able to use Face/Touch Unlock using my Mac fingerprint unlock button. Step 19: Security Key and Face or Touch unlock are still not visible given removed config and disabled JavaScript. |
jc-gsa
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Improves
WebauthnInputComponentto avoid handling visibility in JavaScript for simple cases where the input should be visible in all JavaScript-enabled browsers.Why?
WebauthnInputElementJavaScript altogether📜 Testing Plan
config/application.ymland restart your server:config/application.ymlsnippet from Step 8 and restart your server