Skip to content

LG-10390: Remove IRS reproofing from IdV welcome / getting started #8817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 3 commits into from
Jul 20, 2023
Merged

LG-10390: Remove IRS reproofing from IdV welcome / getting started #8817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be6db0e
LG-10390: Remove irs reproofing from welcome
matthinz Jul 20, 2023
e34ad1b
Remove .usa-alert--info-important style
matthinz Jul 20, 2023
1fbb9fd
Remove unused image
matthinz Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/assets/images/alert/info-white.svg
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions app/assets/stylesheets/components/_alert.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,5 @@
@use 'uswds-core' as *;

.usa-alert--info-important {
@include u-bg('accent-cool-darker');
color: color('white');
font-weight: bold;

&::before {
background-image: url('/alert/info-white.svg');
Copy link
Contributor

@aduth aduth Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to remove this file as well.

https://github.com/18F/identity-idp/blob/main/app/assets/images/alert/info-white.svg

}
}

.usa-alert--info-time {
&::before {
@include add-color-icon(
Expand Down
9 changes: 0 additions & 9 deletions app/views/idv/getting_started/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,6 @@
intro: t('idv.getting_started.no_js_intro', sp_name: @sp_name),
) do %>

<% if @current_user&.reproof_for_irs?(service_provider: @current_sp) %>
<%= render AlertComponent.new(
type: :info,
message: t('doc_auth.info.irs_reproofing_explanation'),
class: ['margin-bottom-2', 'usa-alert--info-important'],
)
%>
<% end %>

<%= render AlertComponent.new(
type: :error,
class: [
Expand Down
9 changes: 0 additions & 9 deletions app/views/idv/welcome/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,6 @@
intro: t('idv.welcome.no_js_intro', sp_name: decorated_session.sp_name || APP_NAME),
) do %>

<% if @current_user&.reproof_for_irs?(service_provider: @current_sp) %>
<%= render AlertComponent.new(
type: :info,
message: t('doc_auth.info.irs_reproofing_explanation'),
class: ['margin-bottom-2', 'usa-alert--info-important'],
Copy link
Contributor

@aduth aduth Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the usa-alert--info-important styles too? This was a variant exception added specifically for this alert.

)
%>
<% end %>

<%= render PageHeadingComponent.new.with_content(t('doc_auth.headings.welcome')) %>
<p>
<%= t('doc_auth.info.welcome', sp_name: decorated_session.sp_name || APP_NAME) %>
Expand Down
1 change: 0 additions & 1 deletion config/locales/doc_auth/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ en:
interstitial_eta: This might take up to a minute. We’ll load the next step
automatically when it’s done.
interstitial_thanks: Thanks for your patience!
irs_reproofing_explanation: As an extra security measure, you must verify your identity again for IRS
keep_window_open: Do not close this window.
learn_more: Learn more about how we protect your sensitive information
lets_go: 'Identity verification happens in two parts:'
Expand Down
2 changes: 0 additions & 2 deletions config/locales/doc_auth/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,6 @@ es:
interstitial_eta: Esto puede tardar hasta un minuto. Cargaremos el siguiente
paso automáticamente cuando esté terminado.
interstitial_thanks: '¡Gracias por su paciencia!'
irs_reproofing_explanation: Como medida adicional de seguridad, tiene que
verificar su identidad de nuevo para el Servicio Interno de Impuestos.
keep_window_open: No cierres esta ventana.
learn_more: Obtenga más información sobre cómo protegemos sus datos confidenciales
lets_go: 'La verificación de la identidad se realiza en dos partes:'
Expand Down
2 changes: 0 additions & 2 deletions config/locales/doc_auth/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,6 @@ fr:
interstitial_eta: Cette opération peut prendre jusqu’à une minute. Nous
chargerons automatiquement l’étape suivante lorsqu’elle sera terminée.
interstitial_thanks: Merci de votre patience!
irs_reproofing_explanation: Comme mesure de sécurité supplémentaire, vous devez
vérifier à nouveau votre identité pour l’IRS.
keep_window_open: Ne fermez pas cette fenêtre.
learn_more: En savoir plus sur la façon dont nous protégeons vos informations
confidentielles
Expand Down
15 changes: 0 additions & 15 deletions spec/views/idv/getting_started/show.html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,30 +24,15 @@
end

context 'in doc auth with an authenticated user' do
let(:need_irs_reproofing) { false }

before do
allow(user).to receive(:reproof_for_irs?).and_return(need_irs_reproofing)
assign(:current_user, user)

render
end

it 'does not render the IRS reproofing explanation' do
expect(rendered).not_to have_text(t('doc_auth.info.irs_reproofing_explanation'))
end

it 'renders a link to return to the SP' do
expect(rendered).to have_link(t('links.cancel'))
end

context 'when trying to log in to the IRS' do
let(:need_irs_reproofing) { true }

it 'renders the IRS reproofing explanation' do
expect(rendered).to have_text(t('doc_auth.info.irs_reproofing_explanation'))
end
end
end

context 'during the acuant maintenance window' do
Expand Down
16 changes: 0 additions & 16 deletions spec/views/idv/welcome/show.html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,30 +21,14 @@
end

context 'in doc auth with an authenticated user' do
let(:need_irs_reproofing) { false }

before do
allow(user).to receive(:reproof_for_irs?).and_return(need_irs_reproofing)
assign(:current_user, user)

render
end

it 'does not render the IRS reproofing explanation' do
expect(rendered).not_to have_text(t('doc_auth.info.irs_reproofing_explanation'))
end

it 'renders a link to return to the SP' do
expect(rendered).to have_link(t('links.cancel'))
end

context 'when trying to log in to the IRS' do
let(:need_irs_reproofing) { true }

it 'renders the IRS reproofing explanation' do
expect(rendered).to have_text(t('doc_auth.info.irs_reproofing_explanation'))
end
end
end

context 'during the acuant maintenance window' do
Expand Down