Lg 10190 remove reproof at from profiles 2 of 2#8816
Merged
Conversation
changelog: Internal, Maintenance, Remove unused column from profiles
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
I think we need a separate PR first where we add reproof_at to the Profile class ignored_columns. We have some code that explicitly loads every column to by default, so dropping this column without removing that will cause errors
kbighorse
changed the title
2 tasks
zachmargolis
approved these changes
Jul 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10190
Profiles schema should not have "reproof_at" attribute
🛠 Summary of changes
This PR removes the
reproof_atcolumn from theprofilestable📜 Testing Plan
Provide a checklist of steps to confirm the changes.