LG-10405: Add full address entry form for PO search (behind feature flag) by sheldon-b · Pull Request #8815 · 18F/identity-idp

sheldon-b · 2023-07-20T16:21:43Z

WIP

🎫 Ticket

🛠 Summary of changes

tbd

sheldon-b · 2023-07-20T16:22:33Z

app/javascript/packages/document-capture/components/document-capture.tsx

-  inPersonFullAddressEntryEnabled: Boolean;
 }

-function DocumentCapture({
-  onStepChange = () => {},
-  inPersonFullAddressEntryEnabled,
-}: DocumentCaptureProps) {
+function DocumentCapture({ onStepChange = () => {} }: DocumentCaptureProps) {
  const [formValues, setFormValues] = useState<Record<string, any> | null>(null);
  const [submissionError, setSubmissionError] = useState<Error | undefined>(undefined);
  const [stepName, setStepName] = useState<string | undefined>(undefined);
  const { t } = useI18n();
  const { flowPath } = useContext(UploadContext);
  const { trackSubmitEvent, trackVisitEvent } = useContext(AnalyticsContext);
-  const { inPersonURL } = useContext(InPersonContext);
+  const { inPersonFullAddressEntryEnabled, inPersonURL } = useContext(InPersonContext);


This is addressing Andrew's feedback from the prior PR for a cleaner way to pass the feature flag into the Document Capture context

sheldon-b · 2023-07-20T16:23:28Z

app/javascript/packages/document-capture/context/in-person.ts

+
+  /**
+   * When true users must enter a full address when searching for a Post Office location
+   */
+  inPersonFullAddressEntryEnabled: boolean;


This is addressing Andrew's feedback from the prior PR for a cleaner way to pass the feature flag into the Document Capture context

sheldon-b · 2023-07-20T16:23:33Z

app/javascript/packs/document-capture.tsx

        inPersonURL,
        inPersonOutageMessageEnabled: inPersonOutageMessageEnabled === 'true',
        inPersonOutageExpectedUpdateDate,
+        inPersonFullAddressEntryEnabled: inPersonFullAddressEntryEnabled === 'true',


This is addressing Andrew's feedback from the prior PR for a cleaner way to pass the feature flag into the Document Capture context

sheldon-b · 2023-07-20T16:23:41Z

app/javascript/packs/document-capture.tsx

    DocumentCapture,
    {
      onStepChange: extendSession,
-      inPersonFullAddressEntryEnabled: inPersonFullAddressEntryEnabled === 'true',


This is addressing Andrew's feedback from the prior PR for a cleaner way to pass the feature flag into the Document Capture context

…d full address PO search form

...ocument-capture/components/in-person-location-full-address-entry-post-office-search-step.tsx

app/javascript/packages/document-capture/components/in-person-full-address-search.tsx

aduth · 2023-07-20T20:40:26Z

...ocument-capture/components/in-person-location-full-address-entry-post-office-search-step.tsx

+  // ref allows us to avoid a memory leak
+  const mountedRef = useRef(false);
+
+  useEffect(() => {
+    mountedRef.current = true;
+    return () => {
+      mountedRef.current = false;
+    };
+  }, []);


Looks like a good use case for useIfStillMounted

https://github.com/18F/identity-idp/blob/main/app/javascript/packages/react-hooks/use-if-still-mounted.ts

I created LG-10435 to track this suggestion.

aduth · 2023-07-20T20:43:22Z

...ocument-capture/components/in-person-location-full-address-entry-post-office-search-step.tsx

+        setTimeout(() => {
+          if (mountedRef.current) {
+            setDisabledAddressSearch(false);
+          }
+        }, 250);


Not sure I'm following what and why we're disabling and setting a timeout for an arbitrary time period.

I created LG-10435 to track this suggestion.

aduth · 2023-07-20T20:48:12Z

app/javascript/packages/document-capture/components/in-person-full-address-search.tsx

Is there some custom validation errors we're trying to reset with these calls? I don't see where we're doing that custom validation.

I created LG-10435 to track this suggestion.

…anual-address-entry-form

…-10405-manual-address-entry-form" This reverts commit f0723db, reversing changes made to bad88a8.

tomas-nava · 2023-07-21T01:34:53Z

closing in favor of #8824; comments will be addressed there

Sheldon Bachstein added 7 commits July 19, 2023 19:26

Sloppy working search prototype

1048e1c

Fix labels and error messages

2f2b5ad

Don't search if fields are missing

03ba8cb

Basic feature test

fafef87

Check for whitespace, not empty strings

2124826

Reuse exports from address-search component

eb3185b

Refactor feature flag to use in person context

3195240

sheldon-b commented Jul 20, 2023

View reviewed changes

Sheldon Bachstein added 2 commits July 20, 2023 12:47

Fix type errors

652a87a

changelog: User-Facing Improvements, In-person full address entry, Ad…

b757e40

…d full address PO search form

tomas-nava mentioned this pull request Jul 20, 2023

LG-10405: Add state dropdown #8819

Closed

Sheldon Bachstein added 2 commits July 20, 2023 16:32

Add spec for full address search component

2f57ed7

Add additional specs for full address entry page

bad88a8

sheldon-b force-pushed the sbachstein/lg-10405-manual-address-entry-form branch from bad88a8 to 8b3959b Compare July 20, 2023 20:46

aduth reviewed Jul 20, 2023

View reviewed changes

Merge remote-tracking branch 'origin/main' into sbachstein/lg-10405-m…

f0723db

…anual-address-entry-form

sheldon-b force-pushed the sbachstein/lg-10405-manual-address-entry-form branch from 8b3959b to f0723db Compare July 20, 2023 20:48

Revert "Merge remote-tracking branch 'origin/main' into sbachstein/lg…

845d009

…-10405-manual-address-entry-form" This reverts commit f0723db, reversing changes made to bad88a8.

tomas-nava mentioned this pull request Jul 21, 2023

LG-10405: Implement state select in manual address entry form #8825

Merged

tomas-nava closed this Jul 21, 2023

tomas-nava deleted the sbachstein/lg-10405-manual-address-entry-form branch July 21, 2023 01:35

sheldon-b mentioned this pull request Jul 21, 2023

LG-10405: Implement full address PO search page behind feature flag #8829

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LG-10405: Add full address entry form for PO search (behind feature flag)#8815

LG-10405: Add full address entry form for PO search (behind feature flag)#8815
sheldon-b wants to merge 13 commits intomainfrom
sbachstein/lg-10405-manual-address-entry-form

sheldon-b commented Jul 20, 2023

Uh oh!

sheldon-b Jul 20, 2023 •

edited

Loading

Uh oh!

sheldon-b Jul 20, 2023

Uh oh!

sheldon-b Jul 20, 2023

Uh oh!

sheldon-b Jul 20, 2023

Uh oh!

Uh oh!

Uh oh!

aduth Jul 20, 2023

Uh oh!

tomas-nava Jul 21, 2023

Uh oh!

aduth Jul 20, 2023

Uh oh!

tomas-nava Jul 21, 2023

Uh oh!

aduth Jul 20, 2023

Uh oh!

tomas-nava Jul 21, 2023

Uh oh!

tomas-nava commented Jul 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sheldon-b commented Jul 20, 2023

🎫 Ticket

🛠 Summary of changes

Uh oh!

sheldon-b Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomas-nava commented Jul 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sheldon-b Jul 20, 2023 •

edited

Loading