Skip to content

LG-9499: Add banner to alert user they already tried to verify with a phone number#8768

Merged
amirbey merged 22 commits intomainfrom
amirbey/LG-9499-add-banner-phone-number-already-failed
Jul 26, 2023
Merged

LG-9499: Add banner to alert user they already tried to verify with a phone number#8768
amirbey merged 22 commits intomainfrom
amirbey/LG-9499-add-banner-phone-number-already-failed

Conversation

@amirbey
Copy link
Contributor

@amirbey amirbey commented Jul 12, 2023

🎫 Ticket

LG-9499

🛠 Summary of changes

  • add list of failed phone numbers to idv_session which is added to each time a phone verification fails
  • add list of failed phone numbers to phone form to determine if inputted number has already failed; and, if so show alert message

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Attempt identity verification steps prior to phone verification
  • verify user phone number is present if submitted for MFA
  • submit a failing phone number
  • Click "Try Again" on failure page
  • verify the textfield is empty upon phone page rendering
  • retype the same failed phone number into the phone textfield
  • verify the alert message is present

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

After:

LG-9499-en

LG-9499-fr

LG-9499-sp

@amirbey amirbey self-assigned this Jul 12, 2023
@amirbey amirbey changed the title Amirbey/lg 9499 add banner phone number already failed LG-9499: Add banner to alert user they already tried to verify with a phone number Jul 12, 2023
@amirbey amirbey force-pushed the amirbey/LG-9499-add-banner-phone-number-already-failed branch from e88e5e4 to 05a2ab0 Compare July 14, 2023 18:46
@amirbey amirbey requested review from a team and matthinz July 15, 2023 18:20
@amirbey amirbey marked this pull request as ready for review July 15, 2023 18:22
@amirbey amirbey force-pushed the amirbey/LG-9499-add-banner-phone-number-already-failed branch from 46d875c to e4f824c Compare July 25, 2023 20:41
@amirbey amirbey requested a review from aduth July 25, 2023 22:08
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor comments, but functionally works well 👍

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
@amirbey amirbey merged commit 3fc7f04 into main Jul 26, 2023
@amirbey amirbey deleted the amirbey/LG-9499-add-banner-phone-number-already-failed branch July 26, 2023 14:42
mitchellhenke pushed a commit that referenced this pull request Jul 26, 2023
… phone number (#8768)

* init alert for idv phone input

* Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

* store failed phone step numbers in idv_session

* check inputted number to see if prvsiously submitted in e164

* display alert for failed nubmers

* phone form does not require failed_numbers and does not default to failed phone number

* add alert messaging for en, fr, es

* happy lintin

changelog: User-Facing Improvements, Identity Verification, alert the user before resubmitting a phone number that failed verification

* do not add failed phone nmber if due to timeout

* make gpo message cond'l

* failed phoned numbers are not auto-populated

* test failed phone resubmission with alert messaging

* demonstrate that valid phone number after invalid phone is successful

* create before block for repeatable setup

* happy linting

* rebase conflict resolved

* add_failed_phone_step_number testing in idv_session

* test that timeout numbers do not render failed alert

* Apply suggestions from code review

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

* refactor handling failed proofing attempts in phone step

* test failed phone numbers added to session

* Apply suggestions from code review

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

---------

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
@amirbey amirbey mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants