Conversation
matthinz
reviewed
Jul 12, 2023
e88e5e4 to
05a2ab0
Compare
aduth
reviewed
Jul 17, 2023
…iled phone number
changelog: User-Facing Improvements, Identity Verification, alert the user before resubmitting a phone number that failed verification
46d875c to
e4f824c
Compare
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
aduth
approved these changes
Jul 26, 2023
Contributor
aduth
left a comment
There was a problem hiding this comment.
Couple minor comments, but functionally works well 👍
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 26, 2023
… phone number (#8768) * init alert for idv phone input * Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * store failed phone step numbers in idv_session * check inputted number to see if prvsiously submitted in e164 * display alert for failed nubmers * phone form does not require failed_numbers and does not default to failed phone number * add alert messaging for en, fr, es * happy lintin changelog: User-Facing Improvements, Identity Verification, alert the user before resubmitting a phone number that failed verification * do not add failed phone nmber if due to timeout * make gpo message cond'l * failed phoned numbers are not auto-populated * test failed phone resubmission with alert messaging * demonstrate that valid phone number after invalid phone is successful * create before block for repeatable setup * happy linting * rebase conflict resolved * add_failed_phone_step_number testing in idv_session * test that timeout numbers do not render failed alert * Apply suggestions from code review Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * refactor handling failed proofing attempts in phone step * test failed phone numbers added to session * Apply suggestions from code review Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9499
🛠 Summary of changes
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
After: