Upgrade dependencies to resolve semver advisory#8752
Merged
Conversation
changelog: Internal, Dependencies, Update dependencies to resolve security advisories
mitchellhenke
approved these changes
Jul 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates dependencies to resolve all security advisories related to semver.
This is a follow-up to #8659, where previously some dependencies could not be updated, since they were pinned to an older version of semver which had not been patched. The older versions have since been patched (
semver@6.3.1,semver@5.7.2), so we can now resolve the advisory completely.The approach largely follows this suggestion to remove and reinstall entries of affected packages from
yarn.lock(specificallysemverandcore-js-compat), as well as upgradingstylelintto the latest version.This removes the
audit-citooling added in #8659, since we don't have a need for an allowlist at the moment, as all advisories have been addressed.📜 Testing Plan
yarn auditproduces a clean result.