Skip to content

LG-9939 Addendum: Make /verify/doc_auth/:step redirect to /verify/welcome #8729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soniaconnolly merged 1 commit into from
Jul 6, 2023
+13 −11
Merged

LG-9939 Addendum: Make /verify/doc_auth/:step redirect to /verify/welcome #8729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@
# deprecated routes
get '/confirmations' => 'personal_key#show'
post '/confirmations' => 'personal_key#update'
get '/doc_auth/:step' => 'welcome#show'
get '/doc_auth/:step', to: redirect('/verify/welcome')
get '/doc_auth/link_sent/poll' => 'capture_doc_status#show'
end

Expand Down
10 changes: 0 additions & 10 deletions spec/controllers/idv/welcome_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,6 @@
end
end

describe 'legacy redirect', type: :routing do
it 'redirects from /verify/doc_auth/:step to idv_welcome_url' do
expect(get('/verify/doc_auth/document_capture')).to route_to(
controller: 'idv/welcome',
action: 'show',
step: 'document_capture',
)
end
end

describe '#show' do
let(:analytics_name) { 'IdV: doc auth welcome visited' }
let(:analytics_args) do
Expand Down
12 changes: 12 additions & 0 deletions spec/requests/redirects_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,16 @@
expect(response).to redirect_to('/verify/by_mail/confirm_start_over')
end
end

describe '/verify/doc_auth/:step' do
it 'redirects to /verify/welcome' do
get '/verify/doc_auth/document_capture'

expect(response).to redirect_to('/verify/welcome')

get '/verify/doc_auth/welcome'

expect(response).to redirect_to('/verify/welcome')
end
end
end