LG-10079: Add authenticator Data flags to Webauthn Configuration#8714
Merged
LG-10079: Add authenticator Data flags to Webauthn Configuration#8714
Conversation
aduth
reviewed
Jul 7, 2023
…tate users to additional information page
aduth
reviewed
Jul 10, 2023
aduth
reviewed
Jul 21, 2023
aduth
approved these changes
Jul 25, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Left a few minor comments, but I tested this locally (non-backed-up) and works well 👍
mdiarra3
changed the title
mdiarra3
changed the title
aduth
reviewed
Jul 31, 2023
Comment on lines
+56
to
+58
| @authenticator_data_flags = process_authenticator_data_value( | ||
| params[:authenticator_data_value], | ||
| ) |
Contributor
There was a problem hiding this comment.
Just flagging that we should expect this value will be validated as nil for some submissions during 50/50 deployment. I think that will be fine here with how we're rescuing ArgumentError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10079: Redirect Webauthn when Backup State is false
🛠 Summary of changes
Under feature toggle we redirect users that their Platform Auth may not be cloud synced to a page that they can continue from. Right now the Page is being designed so this is just the redirecting and detecting.