Skip to content

Remove IE 11 warning banner#8710

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/remove-ie-11
Jul 5, 2023
Merged

Remove IE 11 warning banner#8710
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/remove-ie-11

Conversation

@mitchellhenke
Copy link
Contributor

🛠 Summary of changes

We dropped support for IE 11 over 6 months ago, and while we do have some related tickets to display a more comprehensive notice to all unsupported browsers, we can remove this for now.

@mitchellhenke mitchellhenke requested a review from aduth July 3, 2023 16:37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update the @browser_is_ie11 = browser_is_ie11 inside #new above too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ope, yep, removed

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/remove-ie-11 branch 2 times, most recently from 50e147e to 9279446 Compare July 3, 2023 16:58
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/remove-ie-11 branch from 9279446 to 40669da Compare July 3, 2023 17:05
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

changelog: User-Facing Improvements, Browser Support, Remove Internet Explorer deprecation banner
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/remove-ie-11 branch from 40669da to e1f0656 Compare July 5, 2023 14:30
@mitchellhenke mitchellhenke merged commit 1f18d0a into main Jul 5, 2023
@mitchellhenke mitchellhenke deleted the mitchellhenke/remove-ie-11 branch July 5, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants