LG-10170 rename Throttle to RateLimiter#8706
Merged
soniaconnolly merged 19 commits intomainfrom Jul 5, 2023
Merged
Conversation
changelog: Internal, Refactor, Rename Throttle to RateLimit
zachmargolis
reviewed
Jul 3, 2023
soniaconnolly
changed the title
amirbey
reviewed
Jul 5, 2023
amirbey
reviewed
Jul 5, 2023
| flow_session[:document_capture_session_uuid] | ||
| end | ||
|
|
||
| def throttled? |
Contributor
There was a problem hiding this comment.
nice to get rid of this 🥳
amirbey
reviewed
Jul 5, 2023
|
|
||
| @expires_at = throttle.expires_at | ||
| @expires_at = rate_limiter.expires_at | ||
| render :throttled |
Contributor
There was a problem hiding this comment.
to be changed in follow up ticket/PR?
Contributor
Author
There was a problem hiding this comment.
Yes, I was avoiding changing anything route-related. Could this be changed by changing just the name of the template file? I still think it should be in a followup PR.
…-throttle-to-rate-limit
Merged
This was referenced Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10170
🛠 Summary of changes
Rename Throttle class to RateLimiter, including all uses
Rename Throttle methods that use 'throttle'
Rename throttle variables to rate_limiter
Rename throttled? method to limited?
Rename increment_to_throttled! to increment_to_limited!
Left unchanged for now:
📜 Testing Plan