LG-9335 Move flow_path tracking out of Flow State Machine#8703
Merged
LG-9335 Move flow_path tracking out of Flow State Machine#8703
Conversation
…ow_session to idv_session
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
amirbey
changed the title
amirbey
commented
Jul 3, 2023
| # copied from doc_auth_controller | ||
| def flow_path | ||
| flow_session[:flow_path] | ||
| idv_session.flow_path || flow_session[:flow_path] |
Contributor
Author
There was a problem hiding this comment.
flow_session is still present a few places to handle 50/50 state. will be removed in post-release PR
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
Overall looks great, needs more tweaking for 50/50 state.
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
…ve in post-deploy PR
…ve in post-deploy PR
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
soniaconnolly
approved these changes
Jul 3, 2023
| destination: destination, | ||
| skip_upload_step: mobile_device?, | ||
| flow_path: flow_session[:flow_path], | ||
| flow_path: idv_session.flow_path, |
Contributor
There was a problem hiding this comment.
Noting for myself and anyone else reviewing that this one is ok because idv_session.flow_path is always set earlier on this execution path.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9335
🛠 Summary of changes
Migrate the flow_path from the flow_session to the idv_session for use during remote identity verification
📜 Testing Plan
Automated testing