Remove Redis-specific code for ArcGIS API token caching#8690
Merged
Conversation
…or ArcGIS API token caching
allthesignals
approved these changes
Jun 28, 2023
Contributor
allthesignals
left a comment
allthesignals
left a comment
There was a problem hiding this comment.
Great news! 1 comment.
| ) | ||
| end | ||
|
|
||
| it 'manually sets the expiration' do |
Contributor
There was a problem hiding this comment.
Maybe we can keep this coverage and modify the test here to say something different? There might be value in maintaining coverage for this Redis-backed scenario.
Contributor
Author
There was a problem hiding this comment.
I thought about that, but in this type of scenario the testing rarely pays off.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
🛠 Summary of changes
expires_atrails/rails#45047📜 Testing Plan