Skip to content

LG-9544 - Personal key screen should have simplified content#8688

Merged
amirbey merged 5 commits intomainfrom
amirbey/LG-9544-personal-key-content
Jul 6, 2023
Merged

LG-9544 - Personal key screen should have simplified content#8688
amirbey merged 5 commits intomainfrom
amirbey/LG-9544-personal-key-content

Conversation

@amirbey
Copy link
Contributor

@amirbey amirbey commented Jun 28, 2023 •
edited
Loading

🎫 Ticket

LG-9544

🛠 Summary of changes

Update copy for personal key acknowledgement partial

📜 Testing Plan

  • create an account
  • complete idv verification steps until Personal key page is rendered

NOTE: cannot be merged before GSA-TTS/identity-site#1109

  • personal key help center link to be verified

👀 Screenshots

Before:

LG-9544-before-en

LG-9544-before-es

LG-9544-before-fr

After:

LG-9544-after-en

LG-9544-after-es

LG-9544-after-fr

@amirbey amirbey self-assigned this Jun 28, 2023
@amirbey amirbey changed the title Amirbey/lg 9544 personal key content LG-9544 - Personal key screen should have simplified content Jun 28, 2023
@amirbey amirbey force-pushed the amirbey/LG-9544-personal-key-content branch from 74b0f1e to 0b1bf2c Compare June 29, 2023 18:40
@amirbey amirbey marked this pull request as ready for review June 29, 2023 19:46
@amirbey amirbey requested a review from a team June 30, 2023 15:30
amirbey
amirbey commented Jun 30, 2023
View reviewed changes
spec/support/features/session_helper.rb Outdated
Copy link
Contributor Author

@amirbey amirbey Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this was using a different/wrong key that had the same text value

soniaconnolly
soniaconnolly approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@soniaconnolly soniaconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM.

I tried the help link, and got "This page is no longer available." at because that PR isn't merged yet. (Now I understand the Do not merge tag.)

@amirbey amirbey force-pushed the amirbey/LG-9544-personal-key-content branch from 571929b to 660b2f8 Compare July 6, 2023 14:05
@amirbey amirbey merged commit 3faa9d6 into main Jul 6, 2023
@amirbey amirbey deleted the amirbey/LG-9544-personal-key-content branch July 6, 2023 14:21
@soniaconnolly soniaconnolly mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@soniaconnolly soniaconnolly soniaconnolly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@amirbey amirbey

Labels

status - do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amirbey @soniaconnolly